Skip to content
This repository was archived by the owner on Dec 18, 2018. It is now read-only.

ConnectionClosed not fired for non-tcp libuv connections #2577

Closed
halter73 opened this issue May 15, 2018 · 3 comments
Closed

ConnectionClosed not fired for non-tcp libuv connections #2577

halter73 opened this issue May 15, 2018 · 3 comments
Labels
bug
Milestone
2.1.3

Comments

@halter73
Copy link
Member

https://github.com/aspnet/KestrelHttpServer/blob/release/2.1/src/Kestrel.Transport.Libuv/Internal/LibuvConnection.cs#L47
@davidfowl
Copy link
Member

Looks like it was intentional? Why was it done this way? Or was it a mistake?

@halter73
Copy link
Member Author

It looks intentional when it's highlighted that way, but it as just boneheaded mistake.

@shirhatti shirhatti added this to the 2.1.1 milestone May 22, 2018
@shirhatti shirhatti added the bug label May 22, 2018
@muratg muratg modified the milestones: 2.1.1, 2.1.3 Jun 4, 2018
@shirhatti
Copy link

Tracked by the PR for #2636

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.1.3
Development

No branches or pull requests
4 participants
@halter73 @davidfowl @muratg @shirhatti