Skip to content
This repository was archived by the owner on Dec 18, 2018. It is now read-only.

Inconsistent package naming #11

Closed
Tratcher opened this issue Jul 1, 2014 · 5 comments
Closed

Inconsistent package naming #11

Tratcher opened this issue Jul 1, 2014 · 5 comments

Comments

@Tratcher
Copy link
Member

Tratcher commented Jul 1, 2014

Helios, WebListener, and Kestrel all use different package naming systems.

Kestrel:

  • Microsoft.AspNet.Server.Kestrel – The actual server
  • Kestrel – IServerFactory, Asp.Net feature interfaces, and a Program.Main that invokes Hosting.Program.Main (??).

WebListener:

  • Microsoft.AspNet.Server.WebListener – The IServerFactory & AspNet feature interfaces
  • Microsoft.Net.Http.Server – The actual server implementation

Helios:

  • Microsoft.AspNet.Loader.IIS - The IServerFactory & AspNet feature interfaces
  • (Several other assemblies for IIS interop)
  • There is a metapackage called Microsoft.AspNet.Server.IIS.

Recommendation:

  • Use the Microsoft.AspNet.Server.* for the components that directly interact with the web stack (IServerFactory, feature interfaces, etc.)
  • Use a product specific name for the package that contains the actual server implementation.
  • For Kestrel this would mean swapping the names of its two packages.
@Eilon
Copy link
Member

Eilon commented Jun 23, 2015

What if we merge all of Kestrel into the Microsoft.AspNet.Server.Kestrel package? I don't think there was a whole lot of value in the short Kestrel name because it wasn't particularly useful on its own.

@Tratcher @lodejard @halter73 @davidfowl

@halter73
Copy link
Member

@DamianEdwards, @lodejard and I decided we could punt this to beta 7.

@halter73 halter73 modified the milestones: 1.0.0-beta7, 1.0.0-beta6 Jul 15, 2015
@halter73
Copy link
Member

I'm OK with merging these into a single Microsoft.AspNet.Server.Kestrel package. Is there any disagreement with this?

@Eilon
Copy link
Member

Eilon commented Jul 29, 2015

Do it.

@lodejard
Copy link
Contributor

Yep

@Eilon Eilon changed the title Inconstant package naming Inconsistent package naming Jul 30, 2015
halter73 added a commit to aspnet/Mvc that referenced this issue Aug 11, 2015
halter73 added a commit to dotnet/aspnetcore that referenced this issue Aug 11, 2015
halter73 added a commit to aspnet/Entropy that referenced this issue Aug 12, 2015
halter73 added a commit to aspnet/dnx that referenced this issue Aug 12, 2015
halter73 added a commit to aspnet/Routing that referenced this issue Aug 12, 2015
halter73 added a commit to aspnet/WebSockets that referenced this issue Aug 12, 2015
halter73 added a commit to aspnet/Security that referenced this issue Aug 12, 2015
halter73 added a commit to aspnet/StaticFiles that referenced this issue Aug 12, 2015
halter73 added a commit to aspnet/ServerTests that referenced this issue Aug 12, 2015
halter73 added a commit to aspnet/MusicStore that referenced this issue Aug 12, 2015
halter73 added a commit to aspnet/Benchmarks that referenced this issue Aug 13, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants