This repository was archived by the owner on Dec 20, 2018. It is now read-only.
Fix doc comments #870
Closed
Fix doc comments #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HaoK thanks! Could you remove CS1591 warning from Microsoft.AspNetCore.Identity/project.json and Microsoft.AspNetCore.Identity.EntityFrameworkCore/project.json and see what happens? |
|
Still missing some doc comments |
|
Can't build it right now :sad: How much is missing? |
|
Not a ton, maybe on the order of 6-10 methods, none of them are very important looking |
|
I think there a couple of new comments in #869. Maybe we should wait until @xperiandri finishes reviewing? 😄 |
|
Other than that LGTM. |
|
@HaoK is it just |
|
Time has pretty much run out, so please get in whatever you can; the rest will have to wait. |
|
Ok I will just check this in as is, we can fix the rest in 1.0.1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@divega @blowdart @Eilon