Skip to content
This repository was archived by the owner on Dec 20, 2018. It is now read-only.

Consider making SignInOrTwoFactorAsync public #1274

Closed
Ponant opened this issue Jun 10, 2017 · 3 comments
Closed

Consider making SignInOrTwoFactorAsync public #1274

Ponant opened this issue Jun 10, 2017 · 3 comments
Labels
3 - Done enhancement
Milestone
2.0.0

Comments

@Ponant
Copy link
Contributor

Ponant commented Jun 10, 2017 •
edited
Loading

Here https://github.com/aspnet/Identity/blob/dev/src/Microsoft.AspNetCore.Identity/SignInManager.cs#L680

This will help in overriding the PasswordSiginInAsync method
https://github.com/aspnet/Identity/blob/dev/src/Microsoft.AspNetCore.Identity/SignInManager.cs#L252
. The method SignInOrTwoFactorAsync is used only in PasswordSiginInAsync and ExternalLoginSignInAsync .
See discussion here https://github.com/aspnet/Identity/issues/1265 . I am happy to PR for this if this sounds reasonable.
Thanks
@HaoK
Copy link
Member

HaoK commented Jun 12, 2017

Feel free to submit a PR, I think protected virtual is more appropriate as this still isn't something Controllers should call directly for example.

@Ponant Ponant mentioned this issue Jun 12, 2017
Merged
@Ponant
Copy link
Contributor Author

Ponant commented Jun 13, 2017

@HaoK ok, done.

HaoK pushed a commit that referenced this issue Jun 14, 2017
@Ponant @HaoK
Enlarged access to SignInOrTwoFactorAsync (#1279)
98263cc 
Does #1274
@HaoK HaoK added this to the 2.0.0 milestone Jun 14, 2017
@HaoK
Copy link
Member

HaoK commented Jun 14, 2017

98263cc

@HaoK HaoK closed this as completed Jun 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
3 - Done enhancement
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@HaoK @Ponant