Skip to content
This repository was archived by the owner on Mar 19, 2019. It is now read-only.

Don't wait indefinitely for requests to drain #298

Closed
davidfowl opened this issue Jan 21, 2017 · 0 comments
Closed

Don't wait indefinitely for requests to drain #298

davidfowl opened this issue Jan 21, 2017 · 0 comments
Assignees
@Tratcher
Labels
3 - Done bug
Milestone
2.0.0-preview1

Comments

@davidfowl
Copy link
Member

Add a timeout on the Wait in MessagePump.Dispose:

HttpSysServer/src/Microsoft.AspNetCore.Server.WebListener/MessagePump.cs

Line 225 in 5fca3b0

_shutdownSignal.WaitOne();

This also needs to be fixed in 1.0.x

/cc @muratg
@davidfowl davidfowl mentioned this issue Jan 21, 2017
Closed
@Tratcher Tratcher self-assigned this Jan 21, 2017
@Tratcher Tratcher added the bug label Jan 21, 2017
Tratcher added a commit that referenced this issue Jan 24, 2017
@Tratcher
#298 Add a timeout for draining requests on shutdown
60d5114
@Tratcher Tratcher mentioned this issue Jan 24, 2017
Merged
Tratcher added a commit that referenced this issue Jan 24, 2017
@Tratcher
#298 Add a timeout for draining requests on shutdown
56bd85a
This was referenced Jan 24, 2017
Closed
Closed
@Tratcher Tratcher added this to the 2.0.0 milestone Jan 24, 2017
@Tratcher Tratcher mentioned this issue Feb 22, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tratcher Tratcher

Labels
3 - Done bug
Projects
None yet
Milestone
2.0.0-preview1
Development

No branches or pull requests
2 participants
@davidfowl @Tratcher