This repository was archived by the owner on Nov 20, 2018. It is now read-only.
Rename UriHelper.Encode #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -80,7 +80,7 @@ public static string Encode(Uri uri) | |||
| { | |||
| if (uri.IsAbsoluteUri) | |||
| { | |||
| return Encode( | |||
| return BuildAbsolute( | |||
There was a problem hiding this comment.
Curious: Why is there not a corresponding BuildRelative call in the else?
There was a problem hiding this comment.
System.Uri has minimal support for relative uris. It won't parse it into path?query#fragment for you. The most it will do is some basic escaping.
|
The Encode => ⌚ |
|
|
||
| namespace SampleApp | ||
| { | ||
| public class Program | ||
| public static class Program |
|
Updated. |
| "dnxcore50" | ||
| ], | ||
| "dependencies": { | ||
| "System.Console": "4.0.0-*", |
There was a problem hiding this comment.
Why do you need this? I think it's pulled in via Microsoft.NETCore.App via NETStandard.Library.
|
|
Tratcher
force-pushed
the
tratcher/urihelper
branch
from
393ff46 to
3fc1fef
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#573 @NTaylorMullen @muratg @strohhut
Also clean up the sample project so it will run again.