This repository was archived by the owner on Dec 19, 2018. It is now read-only.
Add Platform lightup hook #951
Comments
|
@davidfowl when can I review the code? :) |
|
I haven't been working on this. |
davidfowl
added a commit
that referenced
this issue
Mar 11, 2017
- Assemblies that are specified in the "hostingStartupAssemblies" configuration (; delimited) setting can specify assemblies that use an assembly level attribute (HostingStartupAttribute) to specify a type that implements IHostingStartup. This allows hosting environments to extend the IWebHostBuilder with platform specific behavior before the application runs. - If Startup fails and CaptureStartupErrors is true, we'll show the error in the usual Startup page. - Added tests #951
davidfowl
added a commit
that referenced
this issue
Mar 23, 2017
- Assemblies that are specified in the "hostingStartupAssemblies" configuration (; delimited) setting can specify assemblies that use an assembly level attribute (HostingStartupAttribute) to specify a type that implements IHostingStartup. This allows hosting environments to extend the IWebHostBuilder with platform specific behavior before the application runs. - If Startup fails and CaptureStartupErrors is true, we'll show the error in the usual Startup page. - Added tests #951
davidfowl
added a commit
that referenced
this issue
Mar 23, 2017
* Add support for executing IHostingStartup in specified assemblies - Assemblies that are specified in the "hostingStartupAssemblies" configuration (; delimited) setting can specify assemblies that use an assembly level attribute (HostingStartupAttribute) to specify a type that implements IHostingStartup. This allows hosting environments to extend the IWebHostBuilder with platform specific behavior before the application runs. - Added tests - Log errors that occur during load and execution of the IHostingStartup when capture startup errors is off. This happens on start of the application. - Added debug logging on startup to print out the hosted startup assemblies hosting processed #951
|
Follow up items
/cc @glennc |
|
@DamianEdwards and I agreed the exception behavior is correct. I don't think there's anything left to do here but remove the |
|
What was the rational? |
|
Startup errors capturing is on by default with IIS integration and thus Azure. If it's on, and a loaded module fails, it's logged and the app runs as normal. |
|
Am closing this bug (again). We can open new bugs as we find issues with the experience |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
https://github.com/dotnet/core-setup/issues/1597 allows us to do platform lightup on Azure.
We need to implement a hook that allows a server to inject packages and implement a package for Azure App Service that adds the Azure App Service logger.
This issue is for the hook. The implementation would go in the AzureIntegration repo.
The text was updated successfully, but these errors were encountered: