This repository was archived by the owner on Nov 2, 2018. It is now read-only.
Refactoring registrations to extension methods #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
cc @halter73 |
| @@ -12,14 +12,14 @@ namespace Microsoft.Framework.DependencyInjection.Autofac | |||
| public static class AutofacRegistration | |||
| { | |||
| public static void Populate( | |||
| ContainerBuilder builder, | |||
| this ContainerBuilder builder, | |||
| IEnumerable<IServiceDescriptor> descriptors) | |||
| { | |||
| Populate(builder, descriptors, fallbackServiceProvider: null); | |||
There was a problem hiding this comment.
builder.Populate(descriptors, fallbackServiceProvider: null);
|
We were being conservative earlier, and wanted to get more experience with how startup looked before finishing the API polish. Seems like a fine time to come back to this and make improvements. |
sebastienros
force-pushed
the
sebros/registrations
branch
from
3ee8255 to
93c10ef
Compare
sebastienros
added a commit
that referenced
this pull request
Sep 26, 2014
Refactoring registrations to extension methods
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #108