You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 2, 2018. It is now read-only.
AddMvc, AddSignalR, GetDefaultServices, etc... already take in an IConfiguration object and use a ServiceDescriber to pull in replacement service implementations from config.
If you were to create your own ServiceCollection (which is atypical) and pass in an IConfiguration object to the constructor, it would not be respected by AddMvc and family.
For these reasons, we should remove the constructor from ServiceCollection that accepts an IConfiguration object, and stop using ServiceDescriber in ServiceCollection since it doesn't provide as much utility when an IConfiguration object is provided.
The text was updated successfully, but these errors were encountered:
* Remove use of IConfiguration from ServiceCollection
* Removing the Add* methods from IServiceCollection that don't accept an
IServiceDescriptor
Fixes#116#117
* Remove use of IConfiguration from ServiceCollection
* Removing the Add* methods from IServiceCollection that don't accept an
IServiceDescriptor
Fixes#116#117
* Remove use of IConfiguration from ServiceCollection
* Removing the Add* methods from IServiceCollection that don't accept an
IServiceDescriptor
Fixes#116#117
AddMvc, AddSignalR, GetDefaultServices, etc... already take in an IConfiguration object and use a ServiceDescriber to pull in replacement service implementations from config.
If you were to create your own ServiceCollection (which is atypical) and pass in an IConfiguration object to the constructor, it would not be respected by AddMvc and family.
For these reasons, we should remove the constructor from ServiceCollection that accepts an IConfiguration object, and stop using ServiceDescriber in ServiceCollection since it doesn't provide as much utility when an IConfiguration object is provided.
The text was updated successfully, but these errors were encountered: