Skip to content
This repository was archived by the owner on Oct 17, 2018. It is now read-only.

Make DataProtection follow the Options model #121

Closed
javiercn opened this issue Feb 24, 2016 · 3 comments
Closed

Make DataProtection follow the Options model #121

javiercn opened this issue Feb 24, 2016 · 3 comments

Comments

@javiercn
Copy link
Member

This repo requires some cleanup to adapt it to the pattern we follow on other parts of the framework

@guardrex
Copy link

@javiercn ... friendly reminder from those of us in production with bits like ...

services.AddSingleton<IXmlRepository, CustomXmlRepository>();
services.AddSingleton<IXmlEncryptor, CustomXmlEncryptor>();
services.AddSingleton<IXmlDecryptor, CustomXmlDecryptor>();

... let us know if "follow the Options model" means something is about to break (i.e., Announcements repo). Everything here is staged, but surprises can be unsettling.

@Eilon
Copy link
Member

Eilon commented Mar 2, 2016

@guardrex indeed, we'll post announcements about any significant changes - and if we push this change through, it'll count as significant.

@guardrex
Copy link

guardrex commented Mar 2, 2016

@Eilon Cool. I have several apps in production now using these bits. Although everything is staged and tested, it still puts a scare on you 💀 when something unexpectedly goes 💥.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants