KeyVault configuration fails if release version of Microsoft.Azure.KeyVault referenced

[frankbuckley]

Using Microsoft.Extensions.Configuration.AzureKeyVault fails if the project using it (or one of its dependencies) references a release version of Microsoft.Azure.KeyVault.

For example, calling builder.AddAzureKeyVault(...) results in:

Method not found: 'Void Microsoft.Azure.KeyVault.KeyVaultClient..ctor(AuthenticationCallback)'
at Microsoft.Extensions.Configuration.AzureKeyVaultConfigurationExtensions.AddAzureKeyVault(IConfigurationBuilder configurationBuilder, String vault, String clientId, String clientSecret, IKeyVaultSecretManager manager)
at DSE.Services.Api.Startup..ctor(IHostingEnvironment env) in C:\dsedev\src\DSE\Services\src\DSE.Services.Api\Startup.cs:line 42

My guess is this may be because version 2.0.2-preview is referenced?

[divega]

I confirmed that the current Microsoft.Extensions.Configuration.AzureKeyVault package depends on 2.0.2-preview of Microsoft.Azure.KeyVault. The released version of Microsoft.Azure.KeyVault is 2.0.6 and we can asume it has breaking changes from preview.

@muratg @pakrym any reason not to release a new version of the provider in the 1.1.1 timeframe that depends on realeased bits?

[muratg]

@divega Let's triage it with the other 1.1.1 items... cc @Eilon

[Eilon]

How exactly did we release an RTM package that has a preview dependency??

[Eilon]

Logged https://github.com/aspnet/Coherence-Signed/issues/396 to track making sure we don't run into this again.

[pakrym]

Fixed by: #570

[Eilon]

Re-opening because we need this in 1.1.1.

[Eilon]

Plus, you didn't mark the bug as 3-Done! 😄

[pavelbrylov]

Any ETA for 1.1.1 release? We also got this issue today :(

[ryanmcdonnell]

I was able to work around this by duplicating some of the code in the extension class and passing the callback explicitly:

KeyVaultClient.AuthenticationCallback callback = (authority, resource, scope) => GetTokenFromClientSecret(authority, resource, clientId, clientSecret);
var keyVaultClient = new KeyVaultClient(callback);
configurationBuilder.AddAzureKeyVault(vaultUri, keyVaultClient, new CustomSecretManager(applicationIdentifier));

Also needed to copy the GetTokenFromClientSecret method:

private static async Task<string> GetTokenFromClientSecret(string authority, string resource, string clientId, string clientSecret)
{
    var authContext = new AuthenticationContext(authority);
    var clientCred = new ClientCredential(clientId, clientSecret);
    var result = await authContext.AcquireTokenAsync(resource, clientCred);
    return result.AccessToken;
}

Here's the complete file: https://gist.github.com/ryanmcdonnell/e44319bb6d734a6e2c11742313b44231

[Eilon]

@pavelbrylov no ETA, but we hope to get it out as soon as possible in 2017.

[pavelbrylov]

@Eilon Thanks!

[Eilon]

This patch bug is approved. Please use the normal code review process w/ a PR and make sure the fix is in the correct branch, then close the bug and mark it as done.

[tjrobinson]

I'm getting this with Microsoft.Azure.KeyVault 2.3.2 when running from an Azure Function, Debug configuration, .NET 4.6.2.

Method not found: 'Void Microsoft.Azure.KeyVault.KeyVaultClient..ctor(AuthenticationCallback, System.Net.Http.DelegatingHandler[])

[divega]

@pakrym @muratg did you see #569 (comment)?

It seems we depend on version 2.3.1 of Microsoft.Azure.KeyVault, and based on the comment above 2.3.2 could contain breaking changes. Was 2.3.1 intentionally chosen? It happens to be unlisted at https://www.nuget.org/packages/Microsoft.Azure.KeyVault/.

[divega]

@tjrobinson thank you for reporting this. I have created #691 to follow up.

[pakrym]

@divega, it's wasn't intentional we just updated to what was latest at that time.