fix: Unable to edit http repo credentials from ArgoCD UI

[aali309]

Fixes: #22246
This PR fixes the issue where HTTP repository credentials cannot be edited from the ArgoCD UI. Previously, only HTTPS repositories were clickable and editable in the UI. Now both HTTP and HTTPS repositories can be edited.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• The title of the PR conforms to the Toolchain Guide
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).
• My new feature complies with the feature status guidelines.
• I have added a brief description of why this PR is necessary and/or what this PR solves.
• Optional. My organization is added to USERS.md.
• Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

[bunnyshell]

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

• 🚀 /bns:deploy to deploy the environment

[aali309]

[keithchong]

Do we have to add http as a new Connection method, as a separate change, when one wants to create a new repo connection? Or, should the current https be named to http(s), or http/https, or.....?

[aali309]

Do we have to add http as a new Connection method, as a separate change, when one wants to create a new repo connection? Or, should the current https be named to http(s), or http/https, or.....?

The existing HTTPS connection method already handles both HTTP and HTTPS protocols under the hood - we just needed to fix the validation and UI display. Renaming it to HTTP/HTTPS would make sense to better reflect this capability.

[keithchong]

LGTM

[aali309]

@todaywasawesome please give this a quick review. Thnx!

[todaywasawesome]

Thanks looks good!