feat(health): add kyverno Policy resource customization #21552
+291
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
marckhair
commented
Jan 17, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #21552 +/- ##
=========================================
Coverage ? 55.86%
=========================================
Files ? 343
Lines ? 57305
Branches ? 0
=========================================
Hits ? 32016
Misses ? 22647
Partials ? 2642 ☔ View full report in Codecov by Sentry. |
marckhair
commented
Jan 22, 2025
resource_customizations/kyverno.io/Policy/testdata/healthy.yaml
Outdated
Show resolved
Hide resolved
marckhair
commented
Jan 22, 2025
marckhair
changed the title
marckhair
force-pushed
the
feat/add-kyverno-policy-health-test
branch
from
a6756ce to
2917775
Compare
Signed-off-by: Marc Khair <[email protected]>
marckhair
force-pushed
the
feat/add-kyverno-policy-health-test
branch
from
7c4701f to
4919c8c
Compare
|
Can anyone review please? @blakepettersson @crenshaw-dev |
marckhair
commented
Jan 22, 2025
marckhair
commented
Jan 22, 2025
marckhair
commented
Jan 22, 2025
todaywasawesome
approved these changes
Jan 23, 2025
|
@crenshaw-dev can anyone take a look at this please? |
andrii-korotkov-verkada
approved these changes
Feb 7, 2025
|
|
||
| hs.status = "Progressing" | ||
| hs.message = "Waiting for Policy to be ready" | ||
| return hs |
There was a problem hiding this comment.
Can it ever be unhealthy?
There was a problem hiding this comment.
Based on the status conditions I see, I don't think so. I might be wrong, my experience with the Policy objects lifecycle is limited.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding custom health check logic for
kyverno.io/Policyobjects.