Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved nuget version back into csproj to fix package publishing issues #129

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

thomas-mullaly
Copy link
Contributor

I broke the build with my last change because the CI process for publishing nuget packages expects the tag to be in the csproj file. This change moves it back to the right spot.

I also noticed the publish action that's being used is no longer maintained by the author and that it's using set-output which is deprecated and will start failing bulids in June (when Github officially gets rid of it).

@github-actions
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
Ardalis.Result 0% 0% 64
Ardalis.Result.AspNetCore 47% 55% 126
Summary 28% (112 / 401) 49% (53 / 108) 190

@ardalis ardalis merged commit dedb167 into ardalis:main Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants