Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: beta tags enabled for certain integrations #39489

Merged
merged 4 commits into from
Mar 4, 2025

Conversation

AmanAgarwal041
Copy link
Contributor

@AmanAgarwal041 AmanAgarwal041 commented Feb 28, 2025

Description

  • This PR appends a beta tag for the premium integrations if they are rolled out to the users. This also contains the functionality of disabling beta tags from any of the rolled integrations.
  • This PR also solves a bug of duplicate premium integrations (released and upcoming with different letter casing).

Fixes #39486
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.Datasource"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13638370133
Commit: 145758f
Cypress dashboard.
Tags: @tag.Datasource
Spec:


Mon, 03 Mar 2025 19:50:43 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • New Features
    • Introduced a visual "Beta" label to indicate beta status on certain integrations.
    • Enhanced the interface by conditionally displaying the new Beta tag alongside existing status indicators.
    • Defined a set of notable beta integrations to be marked with the Beta tag.
    • Applied updated styling for the Beta tag to ensure a consistent, clear display across the interface.
    • Added functionality to check if plugins are in a beta state.

@AmanAgarwal041 AmanAgarwal041 added the ok-to-test Required label for CI label Feb 28, 2025
Copy link
Contributor

coderabbitai bot commented Feb 28, 2025

Walkthrough

This pull request introduces a Beta labeling feature across the integration editor. A new BETA_TAG function is added to the premium datasource messages, and a constant array BETA_PLUGINS is defined. The UI is updated by conditionally rendering a new BetaTag component in the DatasourceItem, with a corresponding styled component for presentation. The changes adjust both the control flow and style to display a Beta label for designated plugins.

Changes

File(s) Change Summary
app/client/src/ce/constants/messages.ts Added BETA_TAG function returning "Beta".
app/client/src/pages/Editor/IntegrationEditor/APIOrSaasPlugins.tsx
app/client/src/pages/Editor/IntegrationEditor/IntegrationStyledComponents.tsx
Introduced BetaTag visual component with conditional rendering and updated styling/imports to display beta status. Added BETA_PLUGINS constant and isPluginInBetaState function.
app/client/src/pages/Editor/IntegrationEditor/PremiumDatasources/Constants.ts Modified PREMIUM_INTEGRATIONS to a regular constant and added RELEASED_PREMIUM_PLUGINS.
app/client/src/pages/Editor/IntegrationEditor/EmptySearchedPlugins.tsx Updated plugin name processing to lowercase for consistency.
app/client/src/pages/Editor/IntegrationEditor/PremiumDatasources/Helpers.ts Added isPluginInBetaState function to check beta status of plugins.

Possibly related PRs

  • chore: added premium tags datasources for knowing users request to add new integrations #38110: The changes in the main PR, which add a BETA_TAG function to the PREMIUM_DATASOURCES constant, are related to the retrieved PR as both involve modifications to the PREMIUM_DATASOURCES constant in the same file, specifically enhancing its functionality.
  • chore: remove zendesk and salesforce from premium tag #39072: The changes in the main PR, which add a BETA_TAG function to the PREMIUM_DATASOURCES constant, are related to the modifications in the retrieved PR that involve the APIOrSaasPlugins.tsx file, where the BetaTag is conditionally rendered based on the beta state of plugins, utilizing the BETA_TAG function.
  • chore: removes premium integration tags for released ones #39472: The changes in the main PR, which introduce a new BETA_TAG function in the PREMIUM_DATASOURCES constant, are related to the retrieved PR as both involve modifications to the APIOrSaasPlugins.tsx file, specifically in how plugins are displayed and filtered, although they focus on different aspects of plugin management.

Suggested labels

Bug, Widgets Product

Suggested reviewers

  • sneha122
  • ApekshaBhosale

Poem

In the code where features play,
A Beta tag finds its way,
New functions and styled art combine,
Guiding users with a subtle sign.
Innovation dances on the screen,
A playful update, sleek and keen!
🚀✨ Enjoy the Beta scene!


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3b6832f and 145758f.

📒 Files selected for processing (1)
  • app/client/src/pages/Editor/IntegrationEditor/APIOrSaasPlugins.tsx (5 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • app/client/src/pages/Editor/IntegrationEditor/APIOrSaasPlugins.tsx
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: perform-test / server-build / server-unit-tests
  • GitHub Check: perform-test / client-build / client-build
  • GitHub Check: perform-test / rts-build / build
  • GitHub Check: client-unit-tests / client-unit-tests
  • GitHub Check: client-lint / client-lint
  • GitHub Check: client-build / client-build
  • GitHub Check: client-check-cyclic-deps / check-cyclic-dependencies
  • GitHub Check: client-prettier / prettier-check

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Pod Integrations Product Issues related to a specific integration Query & JS Pod Issues related to the query & JS Pod Query & Widgets Pod All issues related to Query, JS, Eval, and Widgets Task A simple Todo skip-changelog Adding this label to a PR prevents it from being listed in the changelog labels Feb 28, 2025
@AmanAgarwal041
Copy link
Contributor Author

/build-deploy-preview skip-tests=true

Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/13586918203.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 39489.
recreate: .

Copy link

Deploy-Preview-URL: https://ce-39489.dp.appsmith.com

@AmanAgarwal041 AmanAgarwal041 requested a review from sneha122 March 3, 2025 04:31
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
app/client/src/pages/Editor/IntegrationEditor/PremiumDatasources/Helpers.ts (1)

120-125: Beta state check implementation looks solid

The function correctly identifies plugins in beta state by checking if they're external SaaS plugins that are not in the released list. The case insensitivity handling is consistent with other changes.

Consider adding a JSDoc comment to document the function's purpose:

+/**
+ * Determines if a plugin is in beta state.
+ * External SaaS plugins are considered beta if they're not in the RELEASED_PREMIUM_PLUGINS list.
+ */
export const isPluginInBetaState = (p: Plugin) => {
  return (
    p.type === PluginType.EXTERNAL_SAAS &&
    !RELEASED_PREMIUM_PLUGINS.includes(p.name.toLocaleLowerCase())
  );
};
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 775eec0 and 3b6832f.

📒 Files selected for processing (4)
  • app/client/src/pages/Editor/IntegrationEditor/APIOrSaasPlugins.tsx (4 hunks)
  • app/client/src/pages/Editor/IntegrationEditor/EmptySearchedPlugins.tsx (1 hunks)
  • app/client/src/pages/Editor/IntegrationEditor/PremiumDatasources/Constants.ts (3 hunks)
  • app/client/src/pages/Editor/IntegrationEditor/PremiumDatasources/Helpers.ts (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • app/client/src/pages/Editor/IntegrationEditor/PremiumDatasources/Constants.ts
  • app/client/src/pages/Editor/IntegrationEditor/APIOrSaasPlugins.tsx
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: perform-test / client-build / client-build
  • GitHub Check: perform-test / rts-build / build
  • GitHub Check: perform-test / server-build / server-unit-tests
  • GitHub Check: client-unit-tests / client-unit-tests
  • GitHub Check: client-lint / client-lint
  • GitHub Check: client-check-cyclic-deps / check-cyclic-dependencies
  • GitHub Check: client-build / client-build
  • GitHub Check: client-prettier / prettier-check
🔇 Additional comments (3)
app/client/src/pages/Editor/IntegrationEditor/EmptySearchedPlugins.tsx (1)

47-47: Case insensitivity implementation is a good practice

The change to convert plugin names to lowercase during mapping ensures consistent case-insensitive comparisons. This aligns well with the changes in other files and improves search reliability.

app/client/src/pages/Editor/IntegrationEditor/PremiumDatasources/Helpers.ts (2)

1-1: Appropriate import update

Correctly importing RELEASED_PREMIUM_PLUGINS which is needed for the beta checking logic.


4-4: Required type imports added

Proper import of PluginType enum and Plugin type for type safety.

@AmanAgarwal041 AmanAgarwal041 added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Mar 3, 2025
@AmanAgarwal041 AmanAgarwal041 merged commit ed67367 into release Mar 4, 2025
55 of 59 checks passed
@AmanAgarwal041 AmanAgarwal041 deleted the chore/beta-tags branch March 4, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Pod Integrations Product Issues related to a specific integration ok-to-test Required label for CI Query & JS Pod Issues related to the query & JS Pod Query & Widgets Pod All issues related to Query, JS, Eval, and Widgets skip-changelog Adding this label to a PR prevents it from being listed in the changelog Task A simple Todo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Implement beta tags for the newly launched integrations
2 participants