-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: beta tags enabled for certain integrations #39489
Conversation
WalkthroughThis pull request introduces a Beta labeling feature across the integration editor. A new Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (8)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
/build-deploy-preview skip-tests=true |
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/13586918203. |
Deploy-Preview-URL: https://ce-39489.dp.appsmith.com |
app/client/src/pages/Editor/IntegrationEditor/PremiumDatasources/Constants.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
app/client/src/pages/Editor/IntegrationEditor/PremiumDatasources/Helpers.ts (1)
120-125
: Beta state check implementation looks solidThe function correctly identifies plugins in beta state by checking if they're external SaaS plugins that are not in the released list. The case insensitivity handling is consistent with other changes.
Consider adding a JSDoc comment to document the function's purpose:
+/** + * Determines if a plugin is in beta state. + * External SaaS plugins are considered beta if they're not in the RELEASED_PREMIUM_PLUGINS list. + */ export const isPluginInBetaState = (p: Plugin) => { return ( p.type === PluginType.EXTERNAL_SAAS && !RELEASED_PREMIUM_PLUGINS.includes(p.name.toLocaleLowerCase()) ); };
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
app/client/src/pages/Editor/IntegrationEditor/APIOrSaasPlugins.tsx
(4 hunks)app/client/src/pages/Editor/IntegrationEditor/EmptySearchedPlugins.tsx
(1 hunks)app/client/src/pages/Editor/IntegrationEditor/PremiumDatasources/Constants.ts
(3 hunks)app/client/src/pages/Editor/IntegrationEditor/PremiumDatasources/Helpers.ts
(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
- app/client/src/pages/Editor/IntegrationEditor/PremiumDatasources/Constants.ts
- app/client/src/pages/Editor/IntegrationEditor/APIOrSaasPlugins.tsx
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: perform-test / client-build / client-build
- GitHub Check: perform-test / rts-build / build
- GitHub Check: perform-test / server-build / server-unit-tests
- GitHub Check: client-unit-tests / client-unit-tests
- GitHub Check: client-lint / client-lint
- GitHub Check: client-check-cyclic-deps / check-cyclic-dependencies
- GitHub Check: client-build / client-build
- GitHub Check: client-prettier / prettier-check
🔇 Additional comments (3)
app/client/src/pages/Editor/IntegrationEditor/EmptySearchedPlugins.tsx (1)
47-47
: Case insensitivity implementation is a good practiceThe change to convert plugin names to lowercase during mapping ensures consistent case-insensitive comparisons. This aligns well with the changes in other files and improves search reliability.
app/client/src/pages/Editor/IntegrationEditor/PremiumDatasources/Helpers.ts (2)
1-1
: Appropriate import updateCorrectly importing RELEASED_PREMIUM_PLUGINS which is needed for the beta checking logic.
4-4
: Required type imports addedProper import of PluginType enum and Plugin type for type safety.
Description
Fixes #39486
or
Fixes
Issue URL
Warning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags="@tag.Datasource"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13638370133
Commit: 145758f
Cypress dashboard.
Tags:
@tag.Datasource
Spec:
Mon, 03 Mar 2025 19:50:43 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit