Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add default RTS port in CE #39444

Merged
merged 1 commit into from
Feb 26, 2025
Merged

fix: Add default RTS port in CE #39444

merged 1 commit into from
Feb 26, 2025

Conversation

subhrashisdas
Copy link
Member

@subhrashisdas subhrashisdas commented Feb 26, 2025

Description

Tip

Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.Sanity"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13538744339
Commit: 0c3ee99
Cypress dashboard.
Tags: @tag.Sanity
Spec:


Wed, 26 Feb 2025 08:06:27 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • Chores
    • Updated the application’s default real-time service port configuration. The system now directly uses a default value of 8091 when no explicit port is provided, ensuring consistent connectivity behavior and reducing potential configuration ambiguities. Users relying on default settings will benefit from improved reliability.

Copy link
Contributor

coderabbitai bot commented Feb 26, 2025

Walkthrough

This pull request modifies the default initialization logic for the RTS port. In the Java source file, the conditional check that defaulted the rtsPort to "8091" has been removed. In the properties file, the configuration is updated to supply "8091" as the default when the APPSMITH_RTS_PORT environment variable is not defined. This change shifts the responsibility of providing a default value fully to the configuration file.

Changes

File(s) Summary
app/server/appsmith-server/src/main/java/.../RTSCallerCEImpl.java Removed conditional check that sets a default value for rtsPort in the makeWebClient method.
app/server/appsmith-server/src/main/resources/.../application-ce.properties Updated the RTS port configuration to default to 8091 if APPSMITH_RTS_PORT is not set.

Sequence Diagram(s)

sequenceDiagram
    participant Config as Config Loader
    participant Caller as RTSCallerCEImpl
    participant WebClient as WebClient

    Config->>Caller: Load property 'appsmith.rts.port' (default 8091)
    Caller->>WebClient: Initialize web client with base URL using rtsPort
Loading

Possibly related PRs

Suggested labels

Task, skip-changelog

Suggested reviewers

  • mohanarpit
  • sharat87
  • pratapaprasanna

Poem

In our code, a shift so neat,
Where defaults now in config meet.
The check removed, yet all is right,
With RTS set to "8091" in sight.
Happy coding with a joyful beat!
🚀✨


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a23c457 and 0c3ee99.

📒 Files selected for processing (2)
  • app/server/appsmith-server/src/main/java/com/appsmith/server/helpers/ce/RTSCallerCEImpl.java (0 hunks)
  • app/server/appsmith-server/src/main/resources/application-ce.properties (1 hunks)
💤 Files with no reviewable changes (1)
  • app/server/appsmith-server/src/main/java/com/appsmith/server/helpers/ce/RTSCallerCEImpl.java
🚧 Files skipped from review as they are similar to previous changes (1)
  • app/server/appsmith-server/src/main/resources/application-ce.properties
⏰ Context from checks skipped due to timeout of 90000ms (5)
  • GitHub Check: perform-test / client-build / client-build
  • GitHub Check: perform-test / rts-build / build
  • GitHub Check: perform-test / server-build / server-unit-tests
  • GitHub Check: server-unit-tests / server-unit-tests
  • GitHub Check: server-spotless / spotless-check

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the Bug Something isn't working label Feb 26, 2025
@subhrashisdas subhrashisdas self-assigned this Feb 26, 2025
@subhrashisdas subhrashisdas added the ok-to-test Required label for CI label Feb 26, 2025
@subhrashisdas
Copy link
Member Author

/build-deploy-preview

Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/13538526567.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 39444.
recreate: .

nsarupr
nsarupr previously approved these changes Feb 26, 2025
Copy link
Contributor

@nsarupr nsarupr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me.

Copy link

Deploy-Preview-URL: https://ce-39444.dp.appsmith.com

@subhrashisdas subhrashisdas enabled auto-merge (squash) February 26, 2025 08:05
@subhrashisdas subhrashisdas merged commit e74664c into release Feb 26, 2025
45 checks passed
@subhrashisdas subhrashisdas deleted the fix/rts-port branch February 26, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working ok-to-test Required label for CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants