Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow tags for few metrics #39359

Merged
merged 2 commits into from
Feb 20, 2025
Merged

chore: allow tags for few metrics #39359

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd200f8
allow certain tags
ApekshaBhosale Feb 19, 2025
494eede
function name change
ApekshaBhosale Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion ...r/appsmith-server/src/main/java/com/appsmith/server/configurations/NoTagsMeterFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,27 @@
import io.micrometer.core.instrument.Tags;
import io.micrometer.core.instrument.config.MeterFilter;

import java.util.List;

public class NoTagsMeterFilter implements MeterFilter {
private static final List<String> seriesExceptionList = List.of(
"appsmith.total.plugin.execution", "appsmith.total.server.execution", "appsmith.get.datasource.context");

@Override
public Meter.Id map(Meter.Id id) {
// Remove all tags from the metric
if (id.getName().startsWith("appsmith")) {
if (id.getName().startsWith("appsmith") && !startsWithPrefix(id.getName())) {
return id.replaceTags(Tags.empty());
}
return id;
}

private boolean startsWithPrefix(String metricName) {
for (String prefix : seriesExceptionList) {
if (metricName.startsWith(prefix)) {
return true;
}
}
return false;
}
}
Loading