-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Removed immur dependancy #39324
Conversation
WalkthroughThe changes remove the usage of the Changes
Sequence Diagram(s)sequenceDiagram
participant C as Client
participant G as getConsolidatedDataApi
participant J as JSON Parsing
C->>G: Request consolidated API data
G->>J: Deep copy original response (JSON.parse(JSON.stringify(...)))
alt Deep copy successful
J-->>G: Return deep copied data
G->>G: Update data.featureFlags.data
G->>C: Return updated response
else Error during JSON parsing
J-->>G: Throw error
G->>G: Log error in catch block
G->>C: Return error-handled response
end
sequenceDiagram
participant C as Client
participant F as featureFlagIntercept
participant J as JSON Parsing
C->>F: Provide original feature flags data
F->>J: Deep copy original response (JSON.parse(JSON.stringify(...)))
J-->>F: Return deep copied data
F->>F: Iterate and filter feature flags based on LICENSE_FEATURE_FLAGS
F->>F: Add 'release_app_sidebar_enabled' flag
F->>C: Return modified feature flags data
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
app/client/cypress/support/Objects/FeatureFlags.ts
(2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`app/client/cypress/**/**.*`: Review the following e2e test ...
app/client/cypress/**/**.*
: Review the following e2e test code written using the Cypress test library. Ensure that:
- Follow best practices for Cypress code and e2e automation.
- Avoid using cy.wait in code.
- Avoid using cy.pause in code.
- Avoid using agHelper.sleep().
- Use locator variables for locators and do not use plain strings.
- Use data-* attributes for selectors.
- Avoid Xpaths, Attributes and CSS path.
- Avoid selectors like .btn.submit or button[type=submit].
- Perform logins via API with LoginFromAPI.
- Perform logout via API with LogOutviaAPI.
- Perform signup via API with SignupFromAPI.
- Avoid using it.only.
- Avoid using after and aftereach in test cases.
- Use multiple assertions for expect statements.
- Avoid using strings for assertions.
- Do not use duplicate filenames even with different paths.
- Avoid using agHelper.Sleep, this.Sleep in any file in code.
app/client/cypress/support/Objects/FeatureFlags.ts
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: perform-test / server-build / server-unit-tests
- GitHub Check: perform-test / rts-build / build
- GitHub Check: client-unit-tests / client-unit-tests
- GitHub Check: client-prettier / prettier-check
- GitHub Check: client-build / client-build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Description
Fixing this error : https://github.com/appsmithorg/appsmith-ee/pull/6115/files
Removed dependencies.
Fixes # https://app.zenhub.com/workspaces/qa-63316faf86bb2e170ed2e46b/issues/gh/appsmithorg/appsmith/39318
Automation
/ok-to-test tags="@tag.All"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13383377889
Commit: 55e9bb0
Cypress dashboard.
Tags:
@tag.All
Spec:
Tue, 18 Feb 2025 05:52:11 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit