fix: fix enum

[znamenskii-ilia]

Description

Tip

Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.Anvil"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13374048716
Commit: 7957ce3
Cypress dashboard.
Tags: @tag.Anvil
Spec:

---

Mon, 17 Feb 2025 16:15:56 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• Bug Fixes
  • Updated the function options list to automatically filter out an unsupported option, ensuring users only see valid choices.

[coderabbitai]

Walkthrough

The pull request updates the selectSystemFunctionEntityOptions function in the selectors module. The function now filters out the assignRequest key from the systemFunctions object before mapping the remaining keys. Additionally, the function signature has been updated to include a return type annotation of FunctionCallingEntityTypeOption[]. A TypeScript comment clarifies that the assignRequest key is only applicable in the EE repository.

Changes

File	Change Summary
app/client/.../selectors.ts	Modified selectSystemFunctionEntityOptions to filter out the assignRequest key and updated the function signature to return FunctionCallingEntityTypeOption[].

Possibly related PRs

• fix: omit assignRequest #39319: Modifies the same function to filter out the assignRequest key, ensuring consistency across repositories.

Suggested reviewers

• ApekshaBhosale
• NandanAnantharamu
• brayn003

Poem

In code we trust, with filters so neat,
Excluding assignRequest makes our logic complete.
Types are in place, clear and defined,
Across EE and CE, consistency aligned.
Cheers to clean code with a touch of delight!
🚀✨

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

app/client/src/components/formControls/FunctionCallingConfigControl/components/selectors.ts (1)

107-116: LGTM! Consider enhancing the TypeScript comment.

The filter implementation and type safety look good. The comment could be more descriptive about why this filtering is necessary.

Consider updating the comment to be more descriptive:

-// @ts-expect-error assignRequest doesn't exist in CE repo but added in EE repo
+// @ts-expect-error: Filtering out 'assignRequest' which is only available in EE (Enterprise Edition) repository to maintain CE (Community Edition) compatibility

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 19cd1ec and 7957ce3.

📒 Files selected for processing (1)

• app/client/src/components/formControls/FunctionCallingConfigControl/components/selectors.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (8)

• GitHub Check: perform-test / client-build / client-build
• GitHub Check: perform-test / server-build / server-unit-tests
• GitHub Check: perform-test / rts-build / build
• GitHub Check: client-unit-tests / client-unit-tests
• GitHub Check: client-lint / client-lint
• GitHub Check: client-check-cyclic-deps / check-cyclic-dependencies
• GitHub Check: client-build / client-build
• GitHub Check: client-prettier / prettier-check