chore: AppIDE Folder Structure #39165
Conversation
|
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 81 files out of 244 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
github-actions
bot
added
the
skip-changelog
github-actions
bot
added
IDE Pod
| import { JsFileIconV2 } from "pages/Editor/Explorer/ExplorerIcons"; | ||
| import { SEARCH_ITEM_TYPES } from "components/editorComponents/GlobalSearch/utils"; | ||
|
|
||
| export const useGroupedAddJsOperations = (): GroupedAddOperations => { |
There was a problem hiding this comment.
nit: Doesn't seem like this is a hook, maybe this should be moved to a constants or a util.
| @@ -0,0 +1,7 @@ | |||
| import type { ReactElement } from "react"; | |||
|
|
|||
| function MissingModuleNotification(): ReactElement | null { | |||
There was a problem hiding this comment.
I think, there should be a to do explaining the intention behind the component.
| import DatasourceBlankState from "pages/Editor/DataSourceEditor/DatasourceBlankState"; | ||
| import DatasourceForm from "pages/Editor/SaaSEditor/DatasourceForm"; | ||
|
|
||
| export const MainPaneRoutes = (path: string) => [ |
There was a problem hiding this comment.
Generally we don't use capitalized naming for util functions to differentiate them from classes/components (same for QueryEditorRoutes).
| import { lazy } from "react"; | ||
| import { retryPromise } from "utils/AppsmithUtils"; | ||
|
|
||
| export const FirstTimeUserOnboardingChecklist = lazy(async () => |
There was a problem hiding this comment.
Looks like the naming could be a bit better here.
hetunandu
added
ok-to-test
# Conflicts: # app/client/src/pages/Editor/JSEditor/AppJSEditorContextMenu.tsx
…ore/app-ide-structure
hetunandu
requested review from
ApekshaBhosale and
sagar-qa007
as code owners
Description
Updates the folder structure and file breakup according to the new IDE folder structure
Fixes #39048
Fixes #39049
Fixes #39051
Automation
/ok-to-test tags="@tag.All"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13352717132
Commit: 54cd1a3
Cypress dashboard.
Tags:
@tag.AllSpec:
Sun, 16 Feb 2025 08:44:30 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?