Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Property control spec #38004

Merged
merged 7 commits into from
Dec 9, 2024
Merged

fix: Property control spec #38004

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a81de18
checkign failure
sagar-qa007 Dec 6, 2024
f66f845
Fix for the case
sagar-qa007 Dec 6, 2024
0841ca5
reverted change
sagar-qa007 Dec 9, 2024
63e8342
Merge branch 'release' into fix/oneclickbindfuncase
sagar-qa007 Dec 9, 2024
dbc877c
Added for ci limit run
sagar-qa007 Dec 9, 2024
09cd0a4
Fix the case
sagar-qa007 Dec 9, 2024
046fc7a
Reverted the change
sagar-qa007 Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/client/cypress/limited-tests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# To run only limited tests - give the spec names in below format:
cypress/e2e/Regression/ClientSide/Templates/Fork_Template_spec.js
cypress/e2e/Regression/ClientSide/OneClickBinding/PropertyControl_spec.ts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Test file exists but contains some test anti-patterns that need attention

  • Found usage of cy.wait(500) which is a flaky test practice. Consider using Cypress's built-in automatic retry and wait mechanisms
  • Test follows proper structure with describe/it blocks and meaningful test descriptions
  • No discouraged selectors found
  • The old Fork_Template_spec file is not present in the codebase
🔗 Analysis chain

Verify the new test specification exists and follows Cypress best practices.

Let's ensure the new test file exists and follows the required guidelines.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the existence and content of the new test file

# Check if the new test file exists
fd "PropertyControl_spec.ts" app/client/cypress

# Check for potential test anti-patterns
rg -A 3 "cy\.wait|cy\.pause|agHelper\.sleep|it\.only|after\(|afterEach\(" "app/client/cypress/e2e/Regression/ClientSide/OneClickBinding/PropertyControl_spec.ts" || echo "No anti-patterns found"

# Check selector usage
rg "\.btn\.submit|button\[type=submit\]|\$\('" "app/client/cypress/e2e/Regression/ClientSide/OneClickBinding/PropertyControl_spec.ts" || echo "No discouraged selectors found"

# Verify login/logout method usage
rg "LoginFromAPI|LogOutviaAPI|SignupFromAPI" "app/client/cypress/e2e/Regression/ClientSide/OneClickBinding/PropertyControl_spec.ts"

Length of output: 802

Script:

#!/bin/bash
# Let's check the content of the test file to verify best practices
cat "app/client/cypress/e2e/Regression/ClientSide/OneClickBinding/PropertyControl_spec.ts"

# Also check if the old test file exists somewhere else
fd "Fork_Template_spec" app/client/cypress

Length of output: 7983

# For running all specs - uncomment below:
#cypress/e2e/**/**/*

Expand Down
Loading