Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Child tab widget doesn't show the icon in Entity explorer #39602

Closed
1 task done
ankitakinger opened this issue Mar 6, 2025 · 0 comments · Fixed by #39605
Closed
1 task done

[Bug]: Child tab widget doesn't show the icon in Entity explorer #39602

ankitakinger opened this issue Mar 6, 2025 · 0 comments · Fixed by #39605
Assignees
@ankitakinger
Labels
Bug Something isn't working IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Needs Triaging Needs attention from maintainers to triage QA Needs QA attention

Comments

@ankitakinger
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Description

Under the feature flag flow for Entity explorer modularisation, when we drag and drop a tabs widget, we are unable to see the left icon for the child tab entities. It shows up in the old flow.
Image

Steps To Reproduce

  1. Login with IDE team creds
  2. Go to any application
  3. Drag and drop a tabs widget on canvas
  4. Notice on the entity explorer, the tabs entity has 2 child entities and each entity should have an icon but thats not the case anymore

Public Sample App

No response

Environment

Production

Severity

Medium (Frustrating UX)

Issue video log

No response

Version

Cloud / Self hosted - Feature flag changes
@ankitakinger ankitakinger added Bug Something isn't working Needs Triaging Needs attention from maintainers to triage labels Mar 6, 2025
@Nikhil-Nandagopal Nikhil-Nandagopal added Medium Issues that frustrate users due to poor UX Production labels Mar 6, 2025
@ankitakinger ankitakinger added IDE Product Issues related to the IDE Product IDE Pod Issues that new developers face while exploring the IDE and removed Production Medium Issues that frustrate users due to poor UX labels Mar 6, 2025
@ankitakinger ankitakinger mentioned this issue Mar 6, 2025
Merged
2 tasks
ankitakinger added a commit that referenced this issue Mar 6, 2025
@ankitakinger
fix: Updating widget tree item props to show the correct icon for chi…
26d1b34 
…ld widgets (#39605)

## Description

Updating widget tree item props to show the correct icon for child
widgets.

Fixes [#39602](#39602)

## Automation

/ok-to-test tags="@tag.IDE"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/13700282344>
> Commit: d67f80f
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13700282344&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.IDE`
> Spec:
> <hr>Thu, 06 Mar 2025 14:24:55 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Enhanced the entity explorer by introducing an optional `type`
classification for each tree item, enabling more detailed visualization.
- Improved icon rendering in widget items by basing visual updates on
each item's `type`, ensuring a consistent display across the interface.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@appsmith-bot appsmith-bot added the QA Needs QA attention label Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ankitakinger ankitakinger

Labels
Bug Something isn't working IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Needs Triaging Needs attention from maintainers to triage QA Needs QA attention
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Updating widget tree item props to show the correct icon for child widgets appsmithorg/appsmith
4 participants
@Nikhil-Nandagopal @hetunandu @ankitakinger @appsmith-bot