Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Fix the failing cypress test for API Multipart #39354

Closed
NilanshBansal opened this issue Feb 19, 2025 · 0 comments · Fixed by #39356
Closed

[Task]: Fix the failing cypress test for API Multipart #39354

NilanshBansal opened this issue Feb 19, 2025 · 0 comments · Fixed by #39356
Assignees
@NilanshBansal
Labels
Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Pod Integrations Product Issues related to a specific integration Query & JS Pod Issues related to the query & JS Pod Query & Widgets Pod All issues related to Query, JS, Eval, and Widgets Task A simple Todo

Comments

@NilanshBansal
Copy link
Contributor

SubTasks

https://theappsmith.slack.com/archives/C0134BAVDB4/p1739942281479499?thread_ts=1739904050.960349&cid=C0134BAVDB4

multipart_form_data_cypress.mp4
@NilanshBansal NilanshBansal added the Task A simple Todo label Feb 19, 2025
@NilanshBansal NilanshBansal self-assigned this Feb 19, 2025
@NilanshBansal NilanshBansal added Query & JS Pod Issues related to the query & JS Pod Integrations Product Issues related to a specific integration Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Pod Query & Widgets Pod All issues related to Query, JS, Eval, and Widgets labels Feb 19, 2025
@NilanshBansal NilanshBansal mentioned this issue Feb 19, 2025
Merged
2 tasks
NilanshBansal added a commit that referenced this issue Feb 19, 2025
@NilanshBansal
fix: cypress test for multipart/form-data (#39356)
af6540f 
## Description
> This PR fixes the cypress test for API multipart/form-data when the
FilePicker is selected as Base64

We have updated the cypress test to use `{{FilePicker1.files[0].data}}`
instead of `{{FilePicker1.files[0]}}`, this is because for base64 type
file picker we have to use `.data` property to make the file upload work
successfully.
Earlier, while the cypress test was passing with
{{FilePicker1.files[0]}} but the uploaded image was corrupted (please
check the screen recording below).


https://github.com/user-attachments/assets/c8cf07a1-db1c-4065-913a-00d544fe7e2b




Fixes #39354 

## Automation

/ok-to-test tags="@tag.Datasource"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!IMPORTANT]
> 🟣 🟣 🟣 Your tests are running.
> Tests running at:
<https://github.com/appsmithorg/appsmith/actions/runs/13408509228>
> Commit: 7b2360f
> Workflow: `PR Automation test suite`
> Tags: `@tag.Datasource`
> Spec: ``
> <hr>Wed, 19 Feb 2025 08:40:23 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Tests**
  - Updated file upload tests to properly validate file data extraction.
- Added a test scenario for adding new pages to enhance page management
verification.
- Revised page selection during tests for more accurate validation
outcomes.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NilanshBansal NilanshBansal

Labels
Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Pod Integrations Product Issues related to a specific integration Query & JS Pod Issues related to the query & JS Pod Query & Widgets Pod All issues related to Query, JS, Eval, and Widgets Task A simple Todo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: cypress test for multipart/form-data appsmithorg/appsmith
1 participant
@NilanshBansal