Skip to content

Commit

Permalink
chore: git pkg - adding baseIds in package based urls (#38827)
Browse files Browse the repository at this point in the history
## Description
- Renames url param `packageId` to `basePackageId`
- Renames url param `moduleId` to `baseModuleId`
- Modifies package init sagas to use basePackageId instead of packageId


Fixes #38504
Fixes #38503
Fixes #38502

## Automation

/ok-to-test tags="@tag.Module"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/13010301792>
> Commit: 3e762e2
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13010301792&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Module`
> Spec:
> <hr>Tue, 28 Jan 2025 12:49:42 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
	- Added `baseId` property to Module and Package interfaces
- Updated navigation entity matching to use `basePackageId` and
`baseModuleId`

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
  • Loading branch information
brayn003 authored Jan 29, 2025
1 parent 754d3ef commit 927383b
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
1 change: 1 addition & 0 deletions app/client/src/ce/constants/ModuleConstants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ export interface ModuleInputSection {
export interface Module
extends Pick<ModuleMetadata, "pluginId" | "pluginType" | "datasourceId"> {
id: ID;
baseId: ID;
name: string;
packageId: ID;
inputsForm: ModuleInputSection[];
Expand Down
1 change: 1 addition & 0 deletions app/client/src/ce/constants/PackageConstants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ type ID = string;

export interface Package {
id: ID;
baseId: ID;
name: string; // Name of the package.
icon: string;
color: string;
Expand Down
4 changes: 2 additions & 2 deletions app/client/src/navigation/FocusEntity.ts
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@ export interface MatchEntityFromPath {
baseApplicationId?: string;
customSlug?: string;
applicationSlug?: string;
packageId?: string;
moduleId?: string;
basePackageId?: string;
baseModuleId?: string;
workflowId?: string;
pageSlug?: string;
baseApiId?: string;
Expand Down

0 comments on commit 927383b

Please sign in to comment.