Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Deprecate legacy app management helpers #608

Merged
merged 2 commits into from
Apr 29, 2023

Conversation

Dor-bl
Copy link
Collaborator

@Dor-bl Dor-bl commented Apr 28, 2023

Change list

As mentioned in appium/appium#15807, these methods will not be supported anymore.
Related item:
#562
For now, I updated only one Integration test to use the more standard Appium session management, more will follow.

Types of changes

What types of changes are you proposing/introducing to .NET client?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New feature (non-breaking change which adds value to the project)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Documentation

  • Have you proposed a file change/ PR with appium to update documentation?

This can be done by navigating to the documentation section on http://appium.io selecting the appropriate command/endpoint and clicking the 'Edit this doc' link to update the C# example

Integration tests

  • Have you provided integration tests to pass against the beta version of appium? (for Bugfix or New feature)

Details

Please provide more details about changes if it is necessary. If there are new features you can provide code samples which show the way they
work and possible use cases. Also you can create gists with pasted C# code samples or put them here using markdown.
About markdown please read Mastering markdown and Writing on GitHub

@Dor-bl Dor-bl linked an issue Apr 28, 2023 that may be closed by this pull request
@Dor-bl
Copy link
Collaborator Author

Dor-bl commented Apr 28, 2023

Cheers @laolubenson.
@mykola-mokhnach @KazuCocoa your input will be appreciated as well.

@laolubenson
Copy link
Collaborator

Ideally, we should advise users on how to use the mobile script method

@Dor-bl Dor-bl requested review from KazuCocoa and laolubenson April 29, 2023 14:03
@Dor-bl
Copy link
Collaborator Author

Dor-bl commented Apr 29, 2023

@KazuCocoa, @laolubenson I've improved the deprecation messages.
let me know if I missed anything else

Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@Dor-bl Dor-bl merged commit 940fd06 into appium:release/5.0.0 Apr 29, 2023
@Dor-bl Dor-bl deleted the deprecate_legacy_app branch April 29, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat]: Deprecate legacy app management helpers
3 participants