Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix crawler not retrying user handler if there was timeout in the handler #909

Merged
merged 2 commits into from
Jan 17, 2025
Merged

fix: Fix crawler not retrying user handler if there was timeout in the handler #909

merged 2 commits into from
Jan 17, 2025

Conversation

Pijukatel
Copy link
Contributor

@Pijukatel Pijukatel commented Jan 15, 2025 •
edited
Loading

Description

Fix crawler not retrying user handler if there was timeout in the handler.
Add parametrized test with one parameter set skipped with reason #908

Issues

@Pijukatel Pijukatel added bug Something isn't working. t-tooling Issues with this label are in the ownership of the tooling team. labels Jan 15, 2025
@Pijukatel Pijukatel changed the title fix: Fix crawler not retrying user handler if there was timeout in the handler. fix: Fix crawler not retrying user handler if there was timeout in the handler Jan 15, 2025
@github-actions github-actions bot added this to the 106th sprint - Tooling team milestone Jan 15, 2025
@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Jan 15, 2025
@Pijukatel
Skip test for Python versions<3.11.
25106d3 
Test uses asyncio.timeout that was introduced in 3.11
@Pijukatel Pijukatel force-pushed the user-handler-timeout branch from d3efc41 to 25106d3 Compare January 15, 2025 13:50
@Pijukatel Pijukatel marked this pull request as ready for review January 15, 2025 13:55
@Pijukatel Pijukatel requested review from vdusek and janbuchar January 15, 2025 13:57
vdusek
vdusek approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks

janbuchar
janbuchar approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@janbuchar janbuchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@Pijukatel Pijukatel merged commit f4090ef into master Jan 17, 2025
23 checks passed
@Pijukatel Pijukatel deleted the user-handler-timeout branch January 17, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janbuchar janbuchar janbuchar approved these changes

@vdusek vdusek vdusek approved these changes

Assignees

@Pijukatel Pijukatel

Labels
bug Something isn't working. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.
Projects
None yet
Milestone
106th sprint - Tooling team
Development

Successfully merging this pull request may close these issues.

Timeout in user defined handler should cause retry
3 participants
@Pijukatel @janbuchar @vdusek