[ISSUE-378][HugePartition][Part-3] Introduce more metrics about huge partition #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
8 tasks
Codecov Report
@@ Coverage Diff @@
## master #494 +/- ##
============================================
+ Coverage 58.83% 59.49% +0.65%
- Complexity 1707 1759 +52
============================================
Files 206 205 -1
Lines 11508 11539 +31
Branches 1030 1035 +5
============================================
+ Hits 6771 6865 +94
+ Misses 4323 4267 -56
+ Partials 414 407 -7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
advancedxy
reviewed
Jan 17, 2023
server/src/main/java/org/apache/uniffle/server/ShuffleTaskInfo.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/uniffle/server/ShuffleTaskInfo.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/uniffle/server/ShuffleTaskInfo.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/uniffle/server/ShuffleTaskInfo.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/uniffle/server/ShuffleTaskInfo.java
Outdated
Show resolved
Hide resolved
advancedxy
reviewed
Jan 17, 2023
server/src/main/java/org/apache/uniffle/server/ShuffleTaskInfo.java
Outdated
Show resolved
Hide resolved
advancedxy
reviewed
Jan 19, 2023
server/src/main/java/org/apache/uniffle/server/ShuffleTaskInfo.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/uniffle/server/ShuffleTaskInfo.java
Outdated
Show resolved
Hide resolved
advancedxy
reviewed
Jan 19, 2023
| } | ||
|
|
||
| public void markHugePartition(int shuffleId, int partitionId) { | ||
| if (!existHugePartition.get()) { |
There was a problem hiding this comment.
Previously, I was thinking:
if (!existHugePartition.getAndSet(true)) {
ShuffleServerMetrics.gaugeAppWithHugePartitionNum.inc();
ShuffleServerMetrics.counterTotalAppWithHugePartitionNum.inc();
}
But maybe get is cheaper, and we should guide by it first.
advancedxy
reviewed
Jan 19, 2023
|
Generally lgtm, except two minor comments. |
|
LGTM, pending CI passes |
|
PTAL @advancedxy . CI passed |
zuston
pushed a commit
that referenced
this pull request
Apr 26, 2024
### What changes were proposed in this pull request? Fix the metric huge_partition_num. ### Why are the changes needed? A follow-up PR for: #494. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing UTs.
jerqi
pushed a commit
that referenced
this pull request
Apr 30, 2024
### What changes were proposed in this pull request? Fix the metric huge_partition_num. ### Why are the changes needed? A follow-up PR for: #494. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing UTs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Introduce more metrics about huge partition
counter
Gauge
Why are the changes needed?
Having these metrics, we should observe the concrete influence from huge partition for regular partition and huge partition number in one shuffle-server
Does this PR introduce any user-facing change?
No
How was this patch tested?