[WIP] [SPARK-51097] [SS] Split apart SparkPlan metrics and instance metrics #50157
+33
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cloud-fan I was recommended to get your advice on this change, as this is related to #49816 and was merged in recently |
cloud-fan
reviewed
Mar 5, 2025
| /** | ||
| * @return All instance metrics of this SparkPlan. | ||
| */ | ||
| def instanceMetrics: Map[String, SQLMetric] = Map.empty |
There was a problem hiding this comment.
why do we add this method to the base class? It looks specific to the StateStoreWriter operartor.
There was a problem hiding this comment.
You're right, it looks like that part wasn't needed. Reduced the scope, thanks!
ericm-db
reviewed
Mar 5, 2025
| @@ -434,12 +447,12 @@ trait StateStoreWriter | |||
| } | |||
|
|
|||
| protected def setStoreInstanceMetrics( | |||
| instanceMetrics: Map[StateStoreInstanceMetric, Long]): Unit = { | |||
| instanceMetrics.foreach { | |||
| newInstanceMetrics: Map[StateStoreInstanceMetric, Long]): Unit = { | |||
There was a problem hiding this comment.
I guess this is because its conflicting with the var name ?
There was a problem hiding this comment.
Yeah it's a conflict with the variable names, I'll rename this to otherStoreInstanceMetrics to clear this up
zecookiez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
SPARK-51097
This PR aims to fix the issue of instance metrics being propagated all the way to Spark UI, even when uninitialized.
Marked as WIP since the original RocksDB PR's changes were reverted, so I'll be making a separate PR to reintroduce both changes.
Why are the changes needed?
Previously, Spark UI would show every possible instance metric that we pre-allocated for every partition. This led to the SQL tab showing a lot of metrics that are unused.
Does this PR introduce any user-facing change?
This should eliminate instance metrics being shown on Spark UI, leaving only the instance metrics visible from Streaming query progress reports.
How was this patch tested?
Tests were reverified in RocksDBStateStoreIntegrationSuite
I ran some stateful queries and checked on SparkUI to make sure these metrics aren't showing up. Will upload screenshots soon.
Was this patch authored or co-authored using generative AI tooling?
No