Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): improve the start method of test_server #1583

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

caicancai
Copy link
Member

PR Submission Guidelines

Please remove this entire section before submitting your PR.
This section is only for your reference.

🙌 Thank you for contributing to iggy!

To help us incorporate your changes efficiently, please adhere to the following guidelines:

General Coding Remarks

  • Code Formatting: Run cargo fmt to ensure your code adheres to the project's style.
  • Code Linting: Run cargo clippy --all-targets --all-features -- -D warnings to make sure your code is lint-free.
  • Unit Testing: Write or update unit tests to cover your changes.
  • Integration Testing: Write or update integration tests to cover your changes.
  • Project Structure: Follow the iggy project's structure and coding style.
  • Build Integrity: Ensure your code compiles and runs error-free.
  • Check unused dependencies: Run cargo machete to make sure no unused dependencies made their way into your changeset.
  • Sort dependencies: Run cargo sort --workspace so that the content of the toml files stay ordered.

Commit Message Rules

  • Description: Provide a concise description of the changes.
  • Tags: Avoid using GitHub tags like feat: or chore:.
  • Style: Use an imperative style in the subject line (e.g., "Fix bug" rather than "Fixed bug" or "Fixes bug").
  • Brevity: Keep the subject line under 80 characters.
  • Rationale: Explain the 'why' and 'what' of your changes in the summary.
  • Details: Use the body to elaborate on the 'how' of your changes.
  • Context: Include 'before' and 'after' scenarios if applicable.
  • References: Link any relevant issues or PRs in the message body.

Remember: Your contribution is essential to the success of iggy. Please ensure that your PR conforms to these guidelines for a swift and smooth integration process.

Thank you!

hubcio
hubcio previously approved these changes Feb 23, 2025
@caicancai
Copy link
Member Author

caicancai commented Feb 23, 2025

@hubcio I improved the start method of test_server. I may not want to submit it in multiple PRs, which will be more troublesome for you, so I merged it into one PR

@caicancai caicancai changed the title chore(test): remove redundant code chore(test): improve the start method of test_server Feb 23, 2025
@hubcio
Copy link
Contributor

hubcio commented Feb 23, 2025

could you please describe the motivation about this change in the PR description? why is it better? :)

eprintln!("{}", line.unwrap());
}
});
}
self.wait_until_server_has_bound();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please improve it by checking if test server is alive in the method wait_until_server_has_bound()?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants