Use java package name for loading BuildConfig

[kristianheljas]

Platforms affected

Android

Motivation and Context

Resolving BuildConfig using android package name (Context.getPackageName) will only work when java and android package names are the same.

Android package name is effectively its applicationId which does not have to match java package name.
A common practice is to use different android package names for different built variants/flavours, ie:

debug {
	applicationIdSuffix ".debug"
}

Now the applicationId (and android package name) might be something like com.example.debug, but BuildConfig will still resolve by com.example.BuildConfig instead of com.example.debug.ClassName

This pull request resolves issue #513.

Description

Now using java.lang.Class.getPackage() instead of android.content.Context.getPackageName()

Testing

Tested with and without applicationIdSuffix with single Android 9 device.

Checklist

• I've run the tests to see all new and existing tests pass
• I added automated test coverage as appropriate for this change
• Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
• If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
• I've updated the documentation if necessary

[janpio]

(Restart CI)

[codecov-io]

Codecov Report

Merging #751 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #751   +/-   ##
=======================================
  Coverage   66.57%   66.57%           
=======================================
  Files          18       18           
  Lines        1822     1822           
=======================================
  Hits         1213     1213           
  Misses        609      609

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cf3dcf...22c2e81. Read the comment docs.

[brody4hire]

Looks OK to me. It would be great if another member can review this. And I wonder if we can cover this in the test suite?

[knight9999]

This is Good.