-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup: delete old ANT & Eclipse files #1272
Conversation
19f0522
to
91f6fc4
Compare
91f6fc4
to
17ce6f0
Compare
Codecov Report
@@ Coverage Diff @@
## master #1272 +/- ##
=======================================
Coverage 73.26% 73.26%
=======================================
Files 21 21
Lines 1646 1646
=======================================
Hits 1206 1206
Misses 440 440 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably should also remove the VERSION file. Seems it is only referenced from build.xml
Other than that: would be great to get rid of these seemingly long obsolete files.
I will create a separate PR for removing the VERSION file. I think that the file was not from ANT nor Eclipse. I think it was something we created to easily manage the cordova-android version in one location and use it in places like ANT. I think it was apart of the pre-npm registry era. Even through after this PR is merged, there should be no references to this file. I just want to make sure we can easily revert the VERSION drop if there was something unexpected that was not in our radar. As for ANT & Eclipse, these are outdated tools that isnt genrally used or prefered for Android development/release anymore. |
Motivation, Context & Description
Remove old ANT/Eclipse related files.
Testing
npm t
Checklist