-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: release build defaults to aab package type #1268
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1268 +/- ##
==========================================
- Coverage 71.15% 71.12% -0.03%
==========================================
Files 21 21
Lines 1650 1652 +2
==========================================
+ Hits 1174 1175 +1
- Misses 476 477 +1
Continue to review full report at Codecov.
|
Hi @erisu, As a result, if i want an APK for production build or Am i right? |
I do not know the Ionic CLI is structured, how it pipes values to Cordova CLI, or how it is used. But with Cordova CLI, the command is: cordova build android --release -- --packageType=apk I don't know what The build config should work as long as the correct property is defined. For this PR description which mentioned |
Thank you for the clarification. |
Motivation, Context & Description
This PR changes the default package type of the release builds to be
aab
(Android App Bundle). In August, AAB format is required for all new apps.https://developer.android.com/distribute/play-policies#RequirementForNewApps
Exisiting apps can continue to release APK packages till November. To continue to build release APK, append the
--packageType=apk
flag to the build command.Testing
npm t
Checklist