fix: add not null checks to prevent running on destroyed activity #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m running on a destroyed activity
breautek
reviewed
Jan 18, 2021
…nymore (i.e. is destroyed)
Codecov Report
@@ Coverage Diff @@
## master #1148 +/- ##
==========================================
+ Coverage 69.06% 71.74% +2.68%
==========================================
Files 20 21 +1
Lines 1833 1745 -88
==========================================
- Hits 1266 1252 -14
+ Misses 567 493 -74
Continue to review full report at Codecov.
|
|
I think the test failure is a lie, I'll restart the checks. |
|
Let me know if anything else is needed! |
erisu
changed the title
breautek
approved these changes
Mar 27, 2021
|
Thank you for your contribution @secondVISION |
wedgberto
pushed a commit
to wedgberto/cordova-android
that referenced
this pull request
May 17, 2022
…ache#1148) * (android) apache#1002: Add Null Pointer Checks to prevent Cordova from running on a destroyed activity * (android) Add logging statements if Cordova Activity does not exist anymore (i.e. is destroyed) Co-authored-by: Habets Rick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
Motivation and Context
See issue and sample MVP/Videos in : #1002
Fixes #1002
Description
Added null pointer checks around
cordova.getActivity(), to check if the activity hosting Cordova is still alive.Testing
Updated MVP (see issue #1002 ) locally with these changes (also updated gradle but is not pushed in this PR).
Checklist
(platform)if this change only applies to one platform (e.g.(android))