Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prepare): mapImageResources always returning [] #1136

Merged
merged 1 commit into from
Dec 4, 2020

Conversation

raphinesse
Copy link
Contributor

Motivation and Context

I broke mapImageResources when refactoring it to use globbing in #1085. The problem is, that fast-glob will only match files by default while we are looking for directories here.

Description

Pass onlyDirectories option to fast-glob.

@codecov-io
Copy link

codecov-io commented Nov 29, 2020

Codecov Report

Merging #1136 (b4aec3d) into master (97e2d15) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1136      +/-   ##
==========================================
- Coverage   71.19%   71.14%   -0.05%     
==========================================
  Files          21       21              
  Lines        1739     1740       +1     
==========================================
  Hits         1238     1238              
- Misses        501      502       +1     
Impacted Files Coverage Δ
bin/templates/cordova/lib/prepare.js 43.76% <0.00%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97e2d15...b4aec3d. Read the comment docs.

@raphinesse raphinesse merged commit 55feadf into apache:master Dec 4, 2020
@raphinesse raphinesse deleted the fix-map-img-resources branch December 4, 2020 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants