-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android - allow changing min sdk version #1117
Android - allow changing min sdk version #1117
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nitpicks.
No printing of default behaviour Co-authored-by: Norman Breau <[email protected]>
typo + match case of cdvMinSdkVersion Co-authored-by: Norman Breau <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1117 +/- ##
==========================================
+ Coverage 69.71% 70.06% +0.35%
==========================================
Files 20 20
Lines 1806 1784 -22
==========================================
- Hits 1259 1250 -9
+ Misses 547 534 -13
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@breautek what do you think? Should we wait for another review? Or can this be merged now, or should this be merged later? Kind regards |
@timbru31 I completed/resolved your requesting changes. I did learn a bit about Groovy and Gradle with this PR. Nice. If there are still remarks, just let it know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; thanks for addressing my comments.
I'll give it a couple more days or so to give a chance for anybody else to pitch in. Assuming there are no objections I'll merge. |
Tests are green, and there haven't been any objections so I'm merging! Thank you @PieterVanPoyer for your time and effort in preparing this PR and thank you @erisu and @timbru31 for your reviews. |
Platforms affected
Android
Motivation and Context
Give the users the opportunity to overwrite the minSdkVersion without a failing build.
Description
This PR uses the overriden cdvMinSdkVersion if it is provided, else it is defaulted to 22 for now.
Testing
I did ran the Java Android tests.
I tested it in next repo: https://github.com/PieterVanPoyer/cordova-plugin-splashscreen-testing-app/tree/testing/changing-min-sdk-version
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)