Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Bump bundled Google benchmark version #39863

Closed
pitrou opened this issue Jan 31, 2024 · 2 comments · Fixed by #39878
Closed

[C++] Bump bundled Google benchmark version #39863

pitrou opened this issue Jan 31, 2024 · 2 comments · Fixed by #39878
Labels
Component: Benchmarking Component: C++ Type: enhancement
Milestone
16.0.0

Comments

@pitrou
Copy link
Member

pitrou commented Jan 31, 2024

Describe the enhancement requested

Title says it all.

Component(s)

Benchmarking, C++
@pitrou
Copy link
Member Author

pitrou commented Jan 31, 2024

This would pick up useful bugfixes such as google/benchmark#1631

@Cerdore Cerdore mentioned this issue Feb 1, 2024
Merged
pitrou pushed a commit that referenced this issue Feb 12, 2024
@Cerdore
GH-39863: [C++] Thirdparty: Bump google benchmark to 1.8.3 (#39878)
b6313a7 
## Rationale for this change
Bump benchmark to 1.8.3

## What changes are included in this PR?
Bump benchmark to 1.8.3

## Are these changes tested?
Already has testing

## Are there any user-facing changes?
no

* Closes: #39863

Authored-by: xiansen.chen <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
@pitrou pitrou added this to the 16.0.0 milestone Feb 12, 2024
@pitrou
Copy link
Member Author

pitrou commented Feb 12, 2024

@Cerdore Can you post something here so that we can assign the issue to you?

dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@Cerdore @dgreiss
apacheGH-39863: [C++] Thirdparty: Bump google benchmark to 1.8.3 (apa…
2f374a1 
…che#39878)

## Rationale for this change
Bump benchmark to 1.8.3

## What changes are included in this PR?
Bump benchmark to 1.8.3

## Are these changes tested?
Already has testing

## Are there any user-facing changes?
no

* Closes: apache#39863

Authored-by: xiansen.chen <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this issue Feb 28, 2024
@Cerdore @zanmato1984
apacheGH-39863: [C++] Thirdparty: Bump google benchmark to 1.8.3 (apa…
38ab79b 
…che#39878)

## Rationale for this change
Bump benchmark to 1.8.3

## What changes are included in this PR?
Bump benchmark to 1.8.3

## Are these changes tested?
Already has testing

## Are there any user-facing changes?
no

* Closes: apache#39863

Authored-by: xiansen.chen <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
thisisnic pushed a commit to thisisnic/arrow that referenced this issue Mar 8, 2024
@Cerdore @thisisnic
apacheGH-39863: [C++] Thirdparty: Bump google benchmark to 1.8.3 (apa…
b5d8f82 
…che#39878)

## Rationale for this change
Bump benchmark to 1.8.3

## What changes are included in this PR?
Bump benchmark to 1.8.3

## Are these changes tested?
Already has testing

## Are there any user-facing changes?
no

* Closes: apache#39863

Authored-by: xiansen.chen <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Benchmarking Component: C++ Type: enhancement
Projects
None yet
Milestone
16.0.0
Development

Successfully merging a pull request may close this issue.

GH-39863: [C++] Thirdparty: Bump google benchmark to 1.8.3 Cerdore/arrow
1 participant
@pitrou