Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support line label formatter config #290

Merged
merged 1 commit into from
Nov 22, 2019
Merged

fix: support line label formatter config #290

merged 1 commit into from
Nov 22, 2019

Conversation

lessmost
Copy link
Member

修复折线图上label相关的配置无效问题，如formatter

@auto-add-label auto-add-label bot added the Bug Something isn't working label Nov 22, 2019
tests-checker[bot]
tests-checker bot suggested changes Nov 22, 2019
View reviewed changes
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@lessmost lessmost requested a review from paleface001 November 22, 2019 14:59
@netlify
Copy link

netlify bot commented Nov 22, 2019 •
edited
Loading

Deploy preview for antv-g2plot ready!

Built with commit df84160

https://deploy-preview-290--antv-g2plot.netlify.com

@paleface001 paleface001 merged commit 9067b09 into master Nov 22, 2019
@paleface001 paleface001 deleted the fix-line-label branch November 22, 2019 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tests-checker tests-checker[bot] tests-checker[bot] requested changes

@paleface001 paleface001 paleface001 approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lessmost @paleface001