Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set local storage before it get it fully #32

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Set local storage before it get it fully #32

wants to merge 3 commits into from

Conversation

varticvasile
Copy link
Contributor

No description provided.

@varticvasile varticvasile force-pushed the defect/wrongSaveToLocaleSorage branch from b32fb81 to 7b4fa0f Compare November 27, 2017 12:10
@andyperlitch
Copy link
Owner

@varticvasile do you think adding the check for the existence of columns to the saveToStorage method makes more sense? These changes seem a little messy to me...

@varticvasile
Copy link
Contributor Author

Yes i did. but it's used in more cases than those 3.

@andyperlitch
Copy link
Owner

Is the problem that saveToStorage is getting called when columns don't exist?

@varticvasile
Copy link
Contributor Author

The problem is that saveToStorage is called before the loadFromStorage has finish. and sets the storage with default data. Not with the last data.

@varticvasile varticvasile force-pushed the defect/wrongSaveToLocaleSorage branch from 6542602 to 5437126 Compare January 18, 2018 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varticvasile @andyperlitch