Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8 support #18

Merged
merged 2 commits into from
Sep 14, 2021
Merged

PHP 8 support #18

merged 2 commits into from
Sep 14, 2021

Conversation

danog
Copy link
Contributor

@danog danog commented Sep 4, 2021

On PHP 8, private __sleep methods issue a warning/exception.

On PHP 8, private __sleep methods issue a warning/exception.
@kelunik kelunik merged commit f2fb907 into amphp:master Sep 14, 2021
@kelunik
Copy link
Member

kelunik commented Sep 14, 2021

Thanks!

@danog
Copy link
Contributor Author

danog commented Sep 14, 2021

Yay!
Can I haz tag? <3

kelunik added a commit that referenced this pull request Dec 5, 2021
* master:
  Ignore SysvMessageQueue symbol
  Fix is_resource check on PHP 8+
  Don't run composer-require-checker on 7.1
  Upgrade composer-require-checker and add config
  Migrate to GitHub Actions
  Update LICENSE
  Remove message queue before each test
  Fix private __sleep methods issuing a warning/exception (#18)

# Conflicts:
#	.github/workflows/ci.yml
#	src/PosixSemaphore.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants