Fix: Update chromedriver deps, make install conditional in CI, and fix indexer sync error in cucumber tests #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonpaulos
changed the title
jasonpaulos
changed the title
jasonpaulos
commented
Feb 23, 2024
4 tasks
algorandskiy
approved these changes
Feb 27, 2024
algorandskiy
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves two, independent issues which recently caused our CI build to fail.
Chromedriver
The chromedriver download URL changed recently, which resulted in our circle CI orb and npm dependency to fail to install it.
This PR updates both of those dependencies, as well as adds conditional logic to our circle CI job to only attempt to install chrome & related tools if it's a browser build. This should make the build more resilient, so that at least some jobs can proceed even if something like this happens again.
Indexer Sync Issue
Cucumber integration tests started failing due to a timing issue with indexer catching up to algod.
algorand/algorand-sdk-testing#309 is the test definition fix, and this PR implements the new step which improves synchronization