Update Keccak library to 3.0.0 #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algorandskiy
requested changes
Jul 13, 2020
There was a problem hiding this comment.
Removing the wrapper is fine. The implementation needs to fixed - import does not match to actual call.
@EvanJRichard - our tests do not cover the following branch in HTLC.signTransactionWithHTLCUnlock
} else if (hashFunction == 2) {
|
All right, waiting resolution about the test for |
|
Rebased against |
|
I am cherry picking this with success on node 12.18.0 |
|
@algorandskiy I have added a test for |
algorandskiy
approved these changes
Oct 5, 2020
jasonpaulos
added a commit
that referenced
this pull request
Oct 14, 2020
* Update Keccak library to 3.0.1 - Fixes #126 * Add test for htlc keccak hash function Co-authored-by: Jason Paulos <[email protected]>
Merged
bricerisingalgorand
pushed a commit
to bricerisingalgorand/js-algorand-sdk
that referenced
this pull request
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
keccak256wrapper package is not needed as the only usage in the SDK is already guaranteed to be a buffer. So dropped it and in the process updated thekeccakpackage to 3.0.0 and made it a direct dependency to fix the failure in #126 where the function overloads in the C++ library without arguments where removed from Node.js's V8 bindings.Fixes #126