Client as tower::Service #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows additional layers to be applied to the client. Some default layers can then be used (e.g. always add a user-agent header for the outbound request). The exterior API remains familiar, except that clients must now be mutable, which is consistent with other implementations. This will allow for future APIs (like a cheaply-cloneable client backed by a channel) which add ergonomic extension points.
It contains a type-erased service which is built from components that can add features to the client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the Client to be a tower::Service internally.
This takes advantage of the
tower::Servicetrait and related ecosystemto provide additional helpers and middleware when using a
Client.