Ensure empty strings are set for plural messages #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it didn't work very well to set new plural messages. The msgid and msgid_plural was set as expected. But msgstr[0,1] was not visible in the output at all. This PR fixes that by ensuring that there's always at least an empty translations available for both singular and plural messages. Fixes #30
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it didn't work very well to set new plural messages. The
msgid and msgid_plural was set as expected. But msgstr[0,1] was not
visible in the output at all.
This PR fixes that by ensuring that there's always at least an empty
translations available for both singular and plural messages.
Fixes #30