Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix client cookie handling #111

Merged
merged 3 commits into from
Mar 7, 2018
Merged

Fix client cookie handling #111

merged 3 commits into from
Mar 7, 2018

Conversation

adwhit
Copy link
Contributor

@adwhit adwhit commented Mar 7, 2018

cc #101

@adwhit adwhit changed the title Fix cookie handling Fix client cookie handling Mar 7, 2018
@codecov
Copy link

codecov bot commented Mar 7, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@178f5a1). Click here to learn what that means.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #111   +/-   ##
=========================================
  Coverage          ?   78.99%           
=========================================
  Files             ?       93           
  Lines             ?     9107           
  Branches          ?        0           
=========================================
  Hits              ?     7194           
  Misses            ?     1913           
  Partials          ?        0
Impacted Files Coverage Δ
src/client/response.rs 60.86% <100%> (ø)
src/client/request.rs 78.14% <100%> (ø)
tests/test_client.rs 92.94% <82.6%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 178f5a1...9e0e081. Read the comment docs.

@fafhrd91
Copy link
Member

fafhrd91 commented Mar 7, 2018

Great! Thanks

@fafhrd91 fafhrd91 merged commit b42de6c into actix:master Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants