-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CORS middleware: allowed_headers is defaulting to None #50
Comments
Thanks for report! Btw would you like to join actix and help with development? |
Sure, feel free to add me. I probably won't contribute too much until I get more familiar with actix. |
No problem, you already helped a lot. Also that depends on your interests level, we need to do a lot to make actix usable on higher level. It requires a lot of functionality, like templates integration, better redis, better db integration, virtual hosting support, csrf, websockets client, maybe even http client |
Nested applications |
fixed in master |
The documentation for
CorsBuilder::allowed_headers()
saysThe code is correctly defaulting the internal
headers
value toAll
, but there is no code actually echoing back theAccess-Control-Request-Headers
, it just leaves theAccess-Control-Allow-Headers
header empty.relevant line of code generating the response:
https://github.com/actix/actix-web/blob/master/src/middleware/cors.rs#L303
The text was updated successfully, but these errors were encountered: