Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMQ-2740 - Create events streams per service per action type #2744

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

felixgateru
Copy link
Contributor

What type of PR is this?

This is a refactor as it changes the current streams for events from per service to per service per action type.

What does this do?

  • This pr updates the Publish method of the events interface to include streamID to enable publishing to different streams at the service level.
  • This pr updates all relevent services to use the updated publish method.

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Yes, tests have been updated.

Did you document any new/modified feature?

No

Notes

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

Attention: Patch coverage is 8.91089% with 92 lines in your changes missing coverage. Please review.

Project coverage is 36.11%. Comparing base (88f7172) to head (2ff176b).

Files with missing lines Patch % Lines
users/events/streams.go 0.00% 23 Missing ⚠️
groups/events/streams.go 0.00% 15 Missing ⚠️
domains/events/streams.go 0.00% 14 Missing ⚠️
channels/events/streams.go 0.00% 12 Missing ⚠️
clients/events/streams.go 0.00% 10 Missing ⚠️
mqtt/events/streams.go 0.00% 4 Missing ⚠️
pkg/events/mocks/publisher.go 0.00% 4 Missing ⚠️
pkg/messaging/events/pubsub.go 0.00% 4 Missing ⚠️
pkg/events/store/store_redis.go 0.00% 2 Missing ⚠️
pkg/messaging/events/publisher.go 0.00% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2744      +/-   ##
==========================================
- Coverage   42.26%   36.11%   -6.16%     
==========================================
  Files         350      218     -132     
  Lines       47903    35154   -12749     
==========================================
- Hits        20247    12696    -7551     
+ Misses      25450    21399    -4051     
+ Partials     2206     1059    -1147     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felixgateru felixgateru marked this pull request as ready for review March 3, 2025 15:00
@felixgateru felixgateru requested a review from a team as a code owner March 3, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create stream per action type
1 participant