Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Fix Websocket Adapter #2700

Merged
merged 2 commits into from
Mar 6, 2025
Merged

Conversation

rodneyosodo
Copy link
Member

@rodneyosodo rodneyosodo commented Feb 11, 2025

What type of PR is this?

This is a bug fix PR

What does this do?

This pull request primarily addresses websocket authentication issues by refining the authentication flow in the websocket handlers and includes broader improvements for the MQTT adapter. It introduces new configuration parameters for the MQTT service, updates docker configurations and dependencies.

Which issue(s) does this PR fix/relate to?

No issue

Have you included tests for your changes?

Tested manually

Did you document any new/modified feature?

Notes

To be merged after #2695

sequenceDiagram
    participant Client
    participant Handler
    participant AdapterService
    Client->>Handler: Send AuthPublish/AuthSubscribe Request
    Handler->>Handler: Process token and topic
    Handler->>AdapterService: Call authAccess(token, topic, msgType)
    AdapterService->>AdapterService: Check if clientKey starts with "Client"
    AdapterService->>AdapterService: Extract client secret if condition met
    AdapterService-->>Handler: Return (clientID, clientType, error)
    Handler-->>Client: Return authentication result
Loading

@rodneyosodo rodneyosodo requested a review from a team as a code owner February 11, 2025 12:05
@rodneyosodo rodneyosodo changed the title WS NOISSUE - Fix Websocket Adapter Feb 11, 2025
@rodneyosodo rodneyosodo marked this pull request as draft February 11, 2025 12:08
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 14.70588% with 29 lines in your changes missing coverage. Please review.

Project coverage is 42.01%. Comparing base (5cc3c1b) to head (e6889c6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
ws/handler.go 6.45% 28 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2700      +/-   ##
==========================================
- Coverage   42.26%   42.01%   -0.26%     
==========================================
  Files         350       14     -336     
  Lines       47903      726   -47177     
==========================================
- Hits        20247      305   -19942     
+ Misses      25450      414   -25036     
+ Partials     2206        7    -2199     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rodneyosodo rodneyosodo force-pushed the fix-websocket branch 2 times, most recently from 55c53cb to ddc40fd Compare February 14, 2025 09:01
@rodneyosodo rodneyosodo force-pushed the fix-websocket branch 6 times, most recently from 192b2e0 to 293038d Compare February 26, 2025 09:04
@rodneyosodo rodneyosodo marked this pull request as ready for review February 26, 2025 09:12
@rodneyosodo rodneyosodo force-pushed the fix-websocket branch 2 times, most recently from f3dcaef to e9d81ca Compare February 28, 2025 07:52
Copy link
Collaborator

@dborovcanin dborovcanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rodneyosodo Please update this one.

@rodneyosodo rodneyosodo force-pushed the fix-websocket branch 2 times, most recently from b4d2337 to 791a90e Compare March 5, 2025 20:08
@rodneyosodo rodneyosodo force-pushed the fix-websocket branch 4 times, most recently from 2ff7ed9 to 6e03fed Compare March 6, 2025 05:31
Signed-off-by: Rodney Osodo <[email protected]>
@dborovcanin dborovcanin merged commit b23a8c2 into absmach:main Mar 6, 2025
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants