Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MG-67 - Update Magistrala compose with SuperMQ compose #76

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

felixgateru
Copy link
Contributor

@felixgateru felixgateru commented Mar 3, 2025

What type of PR is this?

This is a refactor as it changes the Magistrala compose use the SuperMQ compose.

What does this do?

This pr:

  • Adds SuperMQ as a subtree package in Magistrala
  • Updates the Magistrala Compose to include the SuperMQ compose.
  • Removes redundant and repeated env variables.

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

No, this is manually tested.

Did you document any new/modified feature?

No

Notes

@felixgateru felixgateru closed this Mar 4, 2025
@felixgateru felixgateru reopened this Mar 4, 2025
@felixgateru felixgateru marked this pull request as ready for review March 4, 2025 12:07
@dborovcanin
Copy link
Contributor

@felixgateru Please resolve conflicts.

Copy link
Contributor

@arvindh123 arvindh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include only the Docker folder and the .env file as a subtree.

Additionally, provide documentation on how to add or update the subtree. For example, if the SuperMQ Docker folder is updated, outline the steps to synchronize those changes with the master branch

@arvindh123
Copy link
Contributor

arvindh123 commented Mar 6, 2025

Please include only the Docker folder and the .env file as a subtree.

Additionally, provide documentation on how to add or update the subtree. For example, if the SuperMQ Docker folder is updated, outline the steps to synchronize those changes with the master branch

We can make the subtree stick to specific tag or version of SMQ

If we need to change version to new version of SMQ, then we can send a PR with git subtree updating to newer version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Magistrala use SuperMQ Compose
3 participants