Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MG-37 - Add Rules Engine tests #74

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

nyagamunene
Copy link
Contributor

@nyagamunene nyagamunene commented Feb 26, 2025

What type of PR is this?

This is a feature because it adds the following functionality:

  • it add test for rules engine i.e. endpoint and service

What does this do?

It add test for rules engine i.e. endpoint and service

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Yes

Did you document any new/modified feature?

No

Notes

Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 90.24390% with 4 lines in your changes missing coverage. Please review.

Project coverage is 33.25%. Comparing base (9c15ba6) to head (b11ce98).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
re/api/transport.go 66.66% 2 Missing and 1 partial ⚠️
re/service.go 96.87% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
+ Coverage   30.12%   33.25%   +3.12%     
==========================================
  Files          89       91       +2     
  Lines       13198    12571     -627     
==========================================
+ Hits         3976     4180     +204     
+ Misses       8752     7970     -782     
+ Partials      470      421      -49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nyagamunene nyagamunene marked this pull request as ready for review February 26, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Rules Engine tests
1 participant