Fix NamedQueryContext not returning sql.ErrNoRows

absmach · Feb 26, 2025 · e26cbf4 · e26cbf4
1 parent 9c15ba6
commit e26cbf4
Showing 1 changed file with 4 additions and 8 deletions.
diff --git a/bootstrap/postgres/configs.go b/bootstrap/postgres/configs.go
@@ -100,15 +100,11 @@ func (cr configRepository) RetrieveByID(ctx context.Context, domainID, id string
 	}
 	row, err := cr.db.NamedQueryContext(ctx, q, dbcfg)
 	if err != nil {
-		if err == sql.ErrNoRows {
-			return bootstrap.Config{}, errors.Wrap(repoerr.ErrNotFound, err)
-		}
-
 		return bootstrap.Config{}, errors.Wrap(repoerr.ErrViewEntity, err)
 	}
 
-	if ok := row.Next(); !ok {
-		return bootstrap.Config{}, errors.Wrap(repoerr.ErrNotFound, row.Err())
+	if !row.Next() {
+		return bootstrap.Config{}, errors.Wrap(repoerr.ErrNotFound, sql.ErrNoRows)
 	}
 
 	if err := row.StructScan(&dbcfg); err != nil {
@@ -211,8 +207,8 @@ func (cr configRepository) RetrieveByExternalID(ctx context.Context, externalID
 		return bootstrap.Config{}, errors.Wrap(repoerr.ErrViewEntity, err)
 	}
 
-	if ok := row.Next(); !ok {
-		return bootstrap.Config{}, errors.Wrap(repoerr.ErrNotFound, row.Err())
+	if !row.Next() {
+		return bootstrap.Config{}, errors.Wrap(repoerr.ErrNotFound, sql.ErrNoRows)
 	}
 
 	if err := row.StructScan(&dbcfg); err != nil {